[
https://issues.apache.org/jira/browse/METRON-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662449#comment-16662449
]
ASF GitHub Bot commented on METRON-1233:
----------------------------------------
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/789
@DimDroll @ottobackwards - All of our topologies pull in the global config.
One such more recent example is that we now provide an option for specifying
batching details for enrichment:
```
enrichment.writer.batchSize
enrichment.writer.batchTimeout
```
The reason for this is that we don't have a global-only-per-topology type
of configuration, with the exception parsers because of how they can be
deployed independently. If you think there's some better clarification that
could be made, I'm open to it. But I think the link between parsers,
enrichment, indexing, and the global configs should be maintained as it is
relevant.
> Remove description of Global configuration from Enrichment doc
> --------------------------------------------------------------
>
> Key: METRON-1233
> URL: https://issues.apache.org/jira/browse/METRON-1233
> Project: Metron
> Issue Type: Improvement
> Reporter: Dima Kovalyov
> Priority: Minor
>
> It confuses reader. Description of Global configuration is available ahead of
> the enrichment and listed here:
> https://metron.apache.org/current-book/metron-platform/metron-common/index.html
> Global config is used for validation of the fields.
> Enrichment is used for fields enrichment and probably can also be used for
> validation of the fields (which is not covered in the doc).
> From available doc I can see that they serve two different purposes.
> So, I don't see any reason to mention global config in enrichment
> description. What's the benefit of knowing about global configuration when
> you want deep dive in enrichment?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
