[
https://issues.apache.org/jira/browse/METRON-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664172#comment-16664172
]
ASF GitHub Bot commented on METRON-1845:
----------------------------------------
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1247
METRON-1845 Correct Test Data Load in Elasticsearch Integration Tests
The Elasticsearch integration tests use the legacy Transport client to load
test data into the search indexes before running the tests. Loading the test
data like this does not accurately reflect how the indices will appear in a
production environment.
This should be changed to use our existing `ElasticsearchUpdateDao` to
write the test data. This ensures that any changes made to the 'write' portion
of our Elasticsearch code will function correctly with the 'read' portion. This
ensures that telemetry written into Elasticsearch by 'Indexing' can be read
correctly by the Alerts UI.
- [ ] Do not merge until after #1242. This change is dependent on #1242.
Take a look at the last commit to view the changes specific to this PR.
## Testing
This only changes the integration tests. If the integration tests pass,
we're golden.
## Pull Request Checklist
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/metron METRON-1845
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1247.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1247
----
commit a7c7dc287b4f9c99c6780b934a0b6f433a03aa04
Author: cstella <cestella@...>
Date: 2018-10-09T00:06:52Z
Casey Stella - elasticsearch rest client migration base work
commit 10410ea9718a2a1b1d287fb4f22a6c98efb1fdaa
Author: Michael Miklavcic <michael.miklavcic@...>
Date: 2018-10-09T00:07:22Z
Update shade plugin version
commit a33a16872118175ed35729df6ddde2959e49ae2f
Author: Michael Miklavcic <michael.miklavcic@...>
Date: 2018-10-09T15:56:08Z
Fix es update dao test
commit 52c3c96d7657205e65d3bd0c0e35923a851911da
Author: Michael Miklavcic <michael.miklavcic@...>
Date: 2018-10-09T21:26:16Z
Merge with master. Fix es search integration tests
commit 4742832869f9512e11cab4a32109c15a2b17a92e
Author: Michael Miklavcic <michael.miklavcic@...>
Date: 2018-10-11T18:45:06Z
Merge branch 'master' into es-rest-client
commit 43809968320e586fd70411776140f3aa13a60195
Author: Michael Miklavcic <michael.miklavcic@...>
Date: 2018-10-11T23:59:25Z
Get shade plugin working with the new ES client and the
ClassIndexTransformer Shade plugin transformer.
commit af03f6f036e96c742db39733bf8ebc2cbf229129
Author: Michael Miklavcic <michael.miklavcic@...>
Date: 2018-10-19T02:56:52Z
Introduce config classes for managing ES client configuration. Translate
properties for new client.
commit 1c8eac2a173e1e24afc9e11163e456a9d90c93db
Author: Michael Miklavcic <michael.miklavcic@...>
Date: 2018-10-23T22:21:32Z
Resolve merge conflicts with master
commit 1a47ded7a36f9d391227973c7da2921305373283
Author: Michael Miklavcic <michael.miklavcic@...>
Date: 2018-10-23T22:23:04Z
Remove extra deps in metron-elasticsearch around log4j.
commit 54870d68e6f43e859367879bff7537f97c11d0bd
Author: Michael Miklavcic <michael.miklavcic@...>
Date: 2018-10-24T00:33:25Z
Fixes for dep version issues.
commit 554de87ae160aae1ae85afb3dbb01a220a9d6838
Author: Nick Allen <nick@...>
Date: 2018-10-25T18:54:41Z
METRON-1845 Correct Test Data Load in Elasticsearch Integration Tests
----
> Correct Test Data Load in Elasticsearch Integration Tests
> ---------------------------------------------------------
>
> Key: METRON-1845
> URL: https://issues.apache.org/jira/browse/METRON-1845
> Project: Metron
> Issue Type: Sub-task
> Reporter: Nick Allen
> Assignee: Nick Allen
> Priority: Major
>
> The Elasticsearch integration tests use the legacy Transport client to load
> test data into the search indexes before running the tests. Loading the test
> data like this does not accurately reflect how the indices will appear in a
> production environment.
> This should be changed to use our existing ElasticsearchUpdateDao to write
> the test data. This ensures that any changes made to the 'write' portion of
> our Elasticsearch code will function correctly with the 'read' portion. This
> ensures that telemetry written into Elasticsearch by 'Indexing' can be read
> correctly by the Alerts UI.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
