[
https://issues.apache.org/jira/browse/METRON-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665549#comment-16665549
]
ASF GitHub Bot commented on METRON-1847:
----------------------------------------
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1248#discussion_r228632953
--- Diff: dev-utilities/committer-utils/prepare-commit ---
@@ -16,242 +16,31 @@
# limitations under the License.
#
-# not likely to change
-METRON_UPSTREAM="https://git-wip-us.apache.org/repos/asf/metron.git";
-BRO_PLUGIN_UPSTREAM="https://git-wip-us.apache.org/repos/asf/metron-bro-plugin-kafka.git";
-CONFIG_FILE=~/.metron-prepare-commit
-GITHUB_REMOTE="origin"
-BASE_BRANCH=master
+LOCATION_DIR=`dirname $0`
+#shellcheck source=./metron-committer-common
--- End diff --
Yes, this a directive for shellcheck
https://github.com/koalaman/shellcheck/wiki/SC1090
https://github.com/koalaman/shellcheck/wiki/Directive
> Create reusable script with functions from prepare-commit
> ---------------------------------------------------------
>
> Key: METRON-1847
> URL: https://issues.apache.org/jira/browse/METRON-1847
> Project: Metron
> Issue Type: Improvement
> Reporter: Otto Fowler
> Assignee: Otto Fowler
> Priority: Major
>
> this will allow code reuse if and when we create more scripts
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
