[ 
https://issues.apache.org/jira/browse/METRON-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675350#comment-16675350
 ] 

ASF GitHub Bot commented on METRON-1855:
----------------------------------------

Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1252#discussion_r230803329
  
    --- Diff: 
metron-platform/metron-enrichment/src/main/scripts/start_enrichment_topology.sh 
---
    @@ -20,7 +20,7 @@ METRON_VERSION=${project.version}
     METRON_HOME=/usr/metron/$METRON_VERSION
     TOPOLOGY_JAR=${project.artifactId}-$METRON_VERSION-uber.jar
     
    -# there are two enrichment topologies.  by default, the split-join 
enrichment topology is executed
    +# There are two enrichment topologies. By default, the unified enrichment 
topology is executed. Split-join is now deprecated.
     SPLIT_JOIN_ARGS="--remote 
$METRON_HOME/flux/enrichment/remote-splitjoin.yaml --filter 
$METRON_HOME/config/enrichment-splitjoin.properties"
     UNIFIED_ARGS="--remote $METRON_HOME/flux/enrichment/remote-unified.yaml 
--filter $METRON_HOME/config/enrichment-unified.properties"
    --- End diff --
    
    We also need to change line 28 of this file so that it defaults to Unified.
    ```
    ARGS=${@:-$UNIFIED_ARGS}
    ```


> Make unified enrichment topology the default and deprecate split-join
> ---------------------------------------------------------------------
>
>                 Key: METRON-1855
>                 URL: https://issues.apache.org/jira/browse/METRON-1855
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Michael Miklavcic
>            Assignee: Michael Miklavcic
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to