[
https://issues.apache.org/jira/browse/METRON-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678736#comment-16678736
]
ASF GitHub Bot commented on METRON-1850:
----------------------------------------
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1250
The latest commit incorporates the changes from
https://github.com/apache/metron/pull/1251 and moves the httpclient inside the
function. I was able to verify proper closing in the REPL and the
EnrichmentIntegrationTest. I was not able to verify in the Storm topologies
because Storm does not guarantee these methods will be called in production. I
added code comments in the bolts where we are calling
`StellarFunctions.close()`.
I spun this up in full dev again and ran through the test plan.
Everything continued to work as expected.
> Stellar REST function
> ---------------------
>
> Key: METRON-1850
> URL: https://issues.apache.org/jira/browse/METRON-1850
> Project: Metron
> Issue Type: New Feature
> Reporter: Ryan Merriman
> Priority: Major
>
> It would be useful to be able to enrich messages with Stellar using 3rd party
> (or internal) REST services. At a minimum this function would:
> * Stellar function available to GET from an HTTP API
> * Optional parameters for basic auth (user/password) which generate correct
> Authorization header
> * Function returns null value for errors, connection failures etc and logs
> error
> * Function must provide and use pooled connection objects at the process
> level
> * Function must send Accept: application/json header
> * A global setting must be available to set a proxy for all API calls, and
> if present the proxy must be used.
> * Proxy authentication must also be supported using basic auth.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
