Github user dopheide-esnet commented on the issue:

    https://github.com/apache/metron-bro-plugin-kafka/pull/18
  
    I chatted with Siwek about it and this is merged into bro-aux as the
    template for future users of init-plugin.
    
    So it’s accepted in that regard as at least a short term solution to help
    packages not break for people.  I wouldn’t mind seeing something a bit 
more
    elegant in the template that can actually check the correct plugin version
    between Bro versions.
    
    Dop
    
    
    On Thu, Nov 15, 2018 at 2:22 PM JonZeolla <[email protected]> wrote:
    
    > So, I did put together a PR meant to handle this @
    > metron-bro-plugin-kafka#8
    >
    > Do you happen to know if your approach is more generally accepted? It
    > feels somewhat strange to say "version" without providing a version number
    > at the very least, but I could see the benefits of having a show-plugin
    > btest that works pre- and post- 2.7.
    >
    > —
    > You are receiving this because you authored the thread.
    > Reply to this email directly, view it on GitHub
    > 
<https://github.com/apache/metron-bro-plugin-kafka/pull/18#issuecomment-439177304>,
    > or mute the thread
    > 
<https://github.com/notifications/unsubscribe-auth/AKtpitEwFHt40y56uAJMb9cpqhV3kYQgks5uvczzgaJpZM4YeZl->
    > .
    >



---

Reply via email to