GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1270
METRON-1880 Use Caffeine for Profiler Caching
Caffeine is a more performant cache when cache sizes are larger. We've
already seen a significant improvement elsewhere in Metron based on the work
done in #947.
The Profiler should use Caffeine for caching to ensure that the caches are
not a performance bottleneck.
## Testing
1. Spin-up Full Dev.
1. Create a profile using the Stellar REPL.
1. Deploy the profile for the Storm-based Profiler.
1. Ensure valid profile data is persisted in HBase.
## Pull Request Checklist
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/metron METRON-1880
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1270.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1270
----
commit 1860b064d6da7d97148507e8235ea825903ac57c
Author: Nick Allen <nick@...>
Date: 2018-11-17T21:20:55Z
METRON-1880 Use Caffeine for Profiler Caching
----
---
