GitHub user JonZeolla opened a pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/19
METRON-1885: Remove version from bro plugin btest
## Contributor Comments
This changes the show-plugin btest so that it should be compatible with bro
2.5-2.7 (as far as we currently know). It is related to #8.
## Testing
An easy way to test this is to use `bro-pkg` to install the plugin (which
runs all of the tests by default), or you can go on a properly configured box
(wrt `btest`) and run `cd metron-bro-plugin-kafka/tests/ && btest -d`.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron's Bro kafka writer
plugin.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [X] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [X] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [X] Have you included steps or a guide to how the change may be verified
and tested manually?
- [X] Have you ensured that the full suite of tests and checks have been
executed via:
```
bro-pkg test $GITHUB_USERNAME/metron-bro-plugin-kafka --version $BRANCH
```
- [X] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Apache Metron's [Vagrant full-dev
environment](https://github.com/apache/metron/tree/master/metron-deployment/development/centos6)
or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JonZeolla/metron-bro-plugin-kafka METRON-1885
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron-bro-plugin-kafka/pull/19.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19
----
commit 241d2261052715d939ba41728f898611a00146fc
Author: Jon Zeolla <zeolla@...>
Date: 2018-11-19T00:04:33Z
METRON-1885: Remove version from bro plugin btest
----
---
