[ 
https://issues.apache.org/jira/browse/METRON-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693575#comment-16693575
 ] 

ASF GitHub Bot commented on METRON-1888:
----------------------------------------

GitHub user nickwallen opened a pull request:

    https://github.com/apache/metron/pull/1276

    METRON-1888 Default Topology Settings in MPack Cause Profiler to Stall

    The default max spout pending set by the Mpack for the Profiler topology is 
300. This value is too low and causes the topology to stall and stop consuming 
messages. 
    
    The Profiler topology is the only Metron topology that uses Storm's 
windowing support.  Storm will queue up messages for the window (by default 30 
seconds) and process each of those windows as one unit.  This causes Storm to 
need to "hang on" to tuples longer than the other topologies and this requires 
a much greater max spout pending value.
    
    This PR restores the original default value prior to #1221 that changed 
this value.  Oops.
    
    ## Pull Request Checklist
    - [ ] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    - [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
    - [ ] Have you included steps or a guide to how the change may be verified 
and tested manually?
    - [ ] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
    
    - [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nickwallen/metron METRON-1888

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1276.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1276
    
----
commit 561232f88b1f6ac9e03178bfe0ea6111c112a717
Author: Nick Allen <nick@...>
Date:   2018-11-20T17:39:59Z

    METRON-1888 Default Topology Settings in MPack Cause Profiler to Stall

----


> Default Topology Settings in MPack Cause Profiler to Stall
> ----------------------------------------------------------
>
>                 Key: METRON-1888
>                 URL: https://issues.apache.org/jira/browse/METRON-1888
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Nick Allen
>            Assignee: Nick Allen
>            Priority: Major
>
> The default max spout pending set by the Mpack for the Profiler topology is 
> 300. This value is too low and causes the topology to stall and stop 
> consuming messages.
>  
> The Profiler topology is the only Metron topology that uses Storm's windowing 
> support.  Storm will queue up messages for the window length (by default 30 
> seconds) and process each of those windows.
>  
> This causes Storm to need to "hang on" to tuples longer than the other 
> topologies and this requires a much greater max spout pending value.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to