Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/1245#discussion_r235117335
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/Constants.java
---
@@ -127,5 +127,40 @@ public String getType() {
}
}
+ public enum ParserConfigConstants {
--- End diff --
Agreed on the previous change regarding use of `static`. In addition, I
think we want to move this list of config parser config constants. The
constants you've added are very specific to this function, and the `Constants`
class is really intended for more global scope items. You can probably just
make this an inner enum in your `RegexParser` class as it's very specific to
that class. Alternatively, you might take a look at @merrimanr 's PR for
Stellar REST calls for an example of where you can put configuration if you
need something more complex -
https://github.com/apache/metron/pull/1250/files#diff-1f3a2a3b1b044494c022cca77223c182.
Again, I think your best off using an inner enum in this case.
---
