[jira] [Commented] (METRON-1885) Remove version from bro plugin btest

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/METRON-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16695019#comment-16695019
 ] 

ASF GitHub Bot commented on METRON-1885:
----------------------------------------

Github user nickwallen commented on the issue:

    https://github.com/apache/metron-bro-plugin-kafka/pull/19
  
    +1 Looks good. Thanks
    
    FYI - Tested with this 
[Dockerfile](https://gist.github.com/nickwallen/3bf2bd4907ae55484b7767066359ffca).
    
    ```
    docker build . --tag=bro-testing
    docker run -it bro-testing /bin/bash
    ```
    
    ```
    [root@0998ab0f716a ~]# bro-pkg install 
http://github.com/JonZeolla/metron-bro-plugin-kafka --version METRON-1885
    The following packages will be INSTALLED:
      http://github.com/JonZeolla/metron-bro-plugin-kafka (METRON-1885)
    
    Verify the following REQUIRED external dependencies:
    (Ensure their installation on all relevant systems before proceeding):
      from http://github.com/JonZeolla/metron-bro-plugin-kafka (METRON-1885):
        librdkafka ~0.11.5
    
    Proceed? [Y/n] Y
    http://github.com/JonZeolla/metron-bro-plugin-kafka asks for 
LIBRDKAFKA_ROOT (Path to librdkafka installation tree) ? [/usr/local/lib]
    Saved answers to config file: /root/.bro-pkg/config
    Running unit tests for "http://github.com/JonZeolla/metron-bro-plugin-kafka";
    all 10 tests successful
    Installing "http://github.com/JonZeolla/metron-bro-plugin-kafka";........
    Installed "http://github.com/JonZeolla/metron-bro-plugin-kafka"; 
(METRON-1885)
    Loaded "http://github.com/JonZeolla/metron-bro-plugin-kafka";
    
    [root@0998ab0f716a ~]# bro -N Apache::Kafka
    Apache::Kafka - Writes logs to Kafka (dynamic, version 0.3)
    ```


> Remove version from bro plugin btest
> ------------------------------------
>
>                 Key: METRON-1885
>                 URL: https://issues.apache.org/jira/browse/METRON-1885
>             Project: Metron
>          Issue Type: Task
>            Reporter: Jon Zeolla
>            Assignee: Jon Zeolla
>            Priority: Minor
>
> We should remove the version from the bro plugin btest to make the transition 
> to a major.minor.patch plugin version (from major.minor, as it currently is) 
> simpler for users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)