Github user JonZeolla commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1261#discussion_r236250814
  
    --- Diff: 
metron-deployment/development/centos6_docker_build/docker_run_ansible.sh ---
    @@ -0,0 +1,46 @@
    +#!/usr/bin/env bash
    +
    +#
    +#  Licensed to the Apache Software Foundation (ASF) under one or more
    +#  contributor license agreements.  See the NOTICE file distributed with
    +#  this work for additional information regarding copyright ownership.
    +#  The ASF licenses this file to You under the Apache License, Version 2.0
    +#  (the "License"); you may not use this file except in compliance with
    +#  the License.  You may obtain a copy of the License at
    +#
    +#      http://www.apache.org/licenses/LICENSE-2.0
    +#
    +#  Unless required by applicable law or agreed to in writing, software
    +#  distributed under the License is distributed on an "AS IS" BASIS,
    +#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +#  See the License for the specific language governing permissions and
    +#  limitations under the License.
    +#
    +
    +
    +#
    +# This script runs IN the docker container
    +#
    +
    +cd /root/metron || exit 1
    +
    +# make sure we have the right c++ tools
    +source /opt/rh/devtoolset-6/enable
    --- End diff --
    
    Consider adding `# shellcheck disable=SC1091` prior.


---

Reply via email to