Github user jagdeepsingh2 commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1245#discussion_r237707637
  
    --- Diff: 
metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/regex/RegularExpressionsParserTest.java
 ---
    @@ -0,0 +1,152 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
    + * agreements. See the NOTICE file distributed with this work for 
additional information regarding
    + * copyright ownership. The ASF licenses this file to you under the Apache 
License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance with the 
License. You may obtain a
    + * copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software 
distributed under the License
    + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
    + * or implied. See the License for the specific language governing 
permissions and limitations under
    + * the License.
    + */
    +package org.apache.metron.parsers.regex;
    +
    +import org.json.simple.JSONObject;
    +import org.json.simple.parser.JSONParser;
    +import org.junit.Before;
    +import org.junit.Test;
    +
    +import java.nio.file.Files;
    +import java.nio.file.Paths;
    +import java.util.HashMap;
    +import java.util.List;
    +import java.util.Map;
    +
    +import static org.junit.Assert.assertTrue;
    +
    +public class RegularExpressionsParserTest {
    +
    +  private RegularExpressionsParser regularExpressionsParser;
    +  private JSONObject parserConfig;
    +
    +  @Before
    +  public void setUp() throws Exception {
    +    regularExpressionsParser = new RegularExpressionsParser();
    +  }
    +
    +  @Test
    +  public void testSSHDParse() throws Exception {
    +    String message =
    +        "<38>Jun 20 15:01:17 deviceName sshd[11672]: Accepted publickey 
for prod from 22.22.22.22 port 55555 ssh2";
    +
    +    parserConfig = getJsonConfig(
    +        
Paths.get("src/test/resources/config/RegularExpressionsParserConfig.json").toString());
    --- End diff --
    
    Actually, parser did parse the message. If you look at the raw_message, it 
is actually the parsed_message. Nowe certainly there is something weird here. 
Not sure why REPL thinks that parser failed and not sure why REPL is putting 
the successfully parsed message into raw_message field. As the parser itself 
has no relation to raw_message field, I think something is wrong with REPL. 
This is the parsed message extracted from the REPL output. So certainly REPL 
got this output from parser. The only way it could have got this output from 
parser is when parser successfully returned from the **parse** methiod.
    
    ```
    {
        "dst_process_id": "11672",
        "dst_process_name": "sshd",
        "source.type": "regex",
        "device_name": "deviceName",
        "original_string": "<38>Jun 20 15:01:17 deviceName sshd[11672]: 
Accepted publickey for prod from 22.22.22.22 port 55555 ssh2",
        "event_info": "Accepted publickey",
        "ip_src_port": "55555",
        "dst_user_id": "prod",
        "app_protocol": "ssh2",
        "guid": "edaee82d-02fb-4ec9-9412-5912fa8d4a6f",
        "syslogpriority": "38",
        "timestamp_device_original": "Jun 20 15:01:17",
        "ip_src_addr": "22.22.22.22"
    }
    ```
    
    Regarding changing the configuration to use @Multiline, I will do that.


---

Reply via email to