Github user JonZeolla commented on a diff in the pull request:

    
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238796550
  
    --- Diff: docker/in_docker_scripts/wait-for-it.sh ---
    @@ -0,0 +1,161 @@
    +#!/usr/bin/env bash
    +#   Use this script to test if a given TCP host/port are available
    +
    +cmdname=$(basename $0)
    --- End diff --
    
    Suggest `cmdname="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && 
pwd )"` as a general good practice.  Probably no specific need if this works, 
since it's a somewhat closed environment.


---

Reply via email to