[
https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709146#comment-16709146
]
ASF GitHub Bot commented on METRON-1911:
----------------------------------------
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238797889
--- Diff: docker/scripts/create_docker_network.sh ---
@@ -0,0 +1,73 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+shopt -s nocasematch
+function help {
+ echo " "
+ echo "usage: ${0}"
+ echo " --network-name [REQUIRED] The docker network
name"
+ echo " -h/--help Usage information."
+ echo " "
+}
+
+NETWORK_NAME=
+
+# handle command line options
+for i in "$@"; do
+ case $i in
+ #
+ # NETWORK_NAME
+ #
+ #
+ #
+ --network-name=*)
+ NETWORK_NAME="${i#*=}"
+ shift # past argument=value
+ ;;
+ #
+ # -h/--help
+ #
+ -h|--help)
+ help
+ exit 0
+ shift # past argument with no value
+ ;;
+
+ #
+ # Unknown option
+ #
+ *)
+ UNKNOWN_OPTION="${i#*=}"
+ echo "Error: unknown option: $UNKNOWN_OPTION"
+ help
+ ;;
+ esac
+done
+
+if [[ -z "$NETWORK_NAME" ]]; then
+ echo "NETWORK_NAME must be passed"
+ exit 1
+fi
+
+docker network create "${NETWORK_NAME}"
+rc=$?; if [[ ${rc} != 0 ]]; then
+exit ${rc};
--- End diff --
No need for `;`, also should indent
> [BROS]Create Docker based test environment for Bro
> --------------------------------------------------
>
> Key: METRON-1911
> URL: https://issues.apache.org/jira/browse/METRON-1911
> Project: Metron
> Issue Type: New Feature
> Reporter: Otto Fowler
> Assignee: Otto Fowler
> Priority: Major
>
> We would benefit from the ability to build and deploy bro, have it run
> against standard pcaps and output to kafka, and capture the logs.
> Using scripts and docker, we should be able to automate this process, as it
> is often written in the prs.
> These scripts could also be used in travis, with cached pcaps for regression
> testing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
