[
https://issues.apache.org/jira/browse/METRON-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709402#comment-16709402
]
ASF GitHub Bot commented on METRON-1849:
----------------------------------------
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/1254#discussion_r238883436
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java
---
@@ -196,7 +196,7 @@ public ElasticsearchDao
withRefreshPolicy(WriteRequest.RefreshPolicy refreshPoli
}
protected Optional<String> getIndexName(String guid, String sensorType)
throws IOException {
- return updateDao.getIndexName(guid, sensorType);
+ return updateDao.findIndexNameByGUID(guid, sensorType);
--- End diff --
Is sensorType not a component to retrieving the index name? Also, would we
want any parity between the updateDao's find method name vs the
ElasticsearchDao's getIndexName method name?
> Elasticsearch Index Write Functionality Should be Shared
> --------------------------------------------------------
>
> Key: METRON-1849
> URL: https://issues.apache.org/jira/browse/METRON-1849
> Project: Metron
> Issue Type: Bug
> Reporter: Nick Allen
> Assignee: Nick Allen
> Priority: Major
>
> The index write functionality is currently duplicated between the
> ElasticsearchWriter and the ElasticsearchUpdateDao. This functionality
> should be de-duplicated and shared between the two.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
