[ 
https://issues.apache.org/jira/browse/METRON-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712906#comment-16712906
 ] 

Nick Allen commented on METRON-1927:
------------------------------------

Got it. Thanks

> Parser Implementations Need Unit Tested with ParserRunner
> ---------------------------------------------------------
>
>                 Key: METRON-1927
>                 URL: https://issues.apache.org/jira/browse/METRON-1927
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Nick Allen
>            Priority: Major
>
> Most of the parser implementations are tested directly in unit tests.  While 
> reviewing a new parser contribution, I found that while all the unit tests 
> pass, [the parser|https://github.com/apache/metron/pull/1245] will not run 
> successfully when deployed to a Metron cluster. 
> This is because the parser was not adding a timestamp field to the messages 
> that it produces. When the parser is run in production using a ParserRunner, 
> additional validation is performed that can cause a parser implementation to 
> not function properly.
> Each parser implementation should be integration tested in the same manner 
> that it  runs in production. To that end, each parser implementation should 
> be tested with a ParserRunner to ensure that the parsers will work when 
> deployed to Metron.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to