[ 
https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714746#comment-16714746
 ] 

ASF GitHub Bot commented on METRON-1911:
----------------------------------------

Github user nickwallen commented on a diff in the pull request:

    
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r240208847
  
    --- Diff: docker/in_docker_scripts/build_bro_plugin.sh ---
    @@ -0,0 +1,48 @@
    +#!/usr/bin/env bash
    +
    +#
    +#  Licensed to the Apache Software Foundation (ASF) under one or more
    +#  contributor license agreements.  See the NOTICE file distributed with
    +#  this work for additional information regarding copyright ownership.
    +#  The ASF licenses this file to You under the Apache License, Version 2.0
    +#  (the "License"); you may not use this file except in compliance with
    +#  the License.  You may obtain a copy of the License at
    +#
    +#      http://www.apache.org/licenses/LICENSE-2.0
    +#
    +#  Unless required by applicable law or agreed to in writing, software
    +#  distributed under the License is distributed on an "AS IS" BASIS,
    +#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +#  See the License for the specific language governing permissions and
    +#  limitations under the License.
    +#
    +
    +shopt -s nocasematch
    +
    +#
    +# Runs bro-package to build and install the plugin
    +#
    +
    +cd /root/code || exit 1
    +
    +
    +make clean
    +
    +rc=$?; if [[ ${rc} != 0 ]]; then
    +  echo "ERROR cleaning project ${rc}" >>"${RUN_LOG_PATH}"
    +  exit ${rc}
    +fi
    +
    +cd /root || exit 1
    +
    +echo "================================" >>"${RUN_LOG_PATH}" 2>&1
    +bro-pkg install code --force | tee "${RUN_LOG_PATH}"
    --- End diff --
    
    Why not install the plugin in the Dockerfile?  That way an image with the 
plugin installed and ready to go can be cached.


> [BROS]Create Docker based test environment for Bro
> --------------------------------------------------
>
>                 Key: METRON-1911
>                 URL: https://issues.apache.org/jira/browse/METRON-1911
>             Project: Metron
>          Issue Type: New Feature
>            Reporter: Otto Fowler
>            Assignee: Otto Fowler
>            Priority: Major
>
> We would benefit from the ability to build and deploy bro, have it run 
> against standard pcaps and output to kafka, and capture the logs.
> Using scripts and docker, we should be able to automate this process, as it 
> is often written in the prs.
> These scripts could also be used in travis, with cached pcaps for regression 
> testing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to