merrimanr commented on issue #1275: METRON-1878: Add Metron as a Knox service URL: https://github.com/apache/metron/pull/1275#issuecomment-447988398 @mmiklavc I've made several updates to the PR. I realized in my testing that for this feature to work correctly, the Knox SSO code should be included so I merged in https://github.com/apache/metron/pull/1281. In addition to resolving those merge conflicts, I also added a unit test for the Knox SSO servlet filter and the documentation you requested. Let me know if the doc makes sense and has enough detail. I'm also debating copying the testing instructions from this PR into the README as Knox setup instructions. A follow on PR that adds this feature to the Mpack is going up soon so are manual instructions worth documenting? I also fixed a couple more UI bugs (login page redirection and the logout bug you mentioned) and tested @sardell's fix in https://github.com/apache/metron/pull/1301. I think that covers points 1, 2, 4, and 5. For 3, I added an inline comment to index.html explaining the relative base path setting. Do you still think we need to add something to the README for this? For 6, I was going to start on it if you haven't already. I've updated the PR description with end to end instructions for testing Knox SSO. I believe this is ready for testing and further review.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
