mmiklavc commented on issue #1279: METRON-1893 Syslog RFC-3164 parser URL: https://github.com/apache/metron/pull/1279#issuecomment-448325447 Adding my 2 cents here, but also happy to add these thoughts to a discuss thread if others want it. I think it definitely makes sense to qualify and justify the libraries we pull into Metron. To that end, we also do depend on many libraries that don't have a big community backing. In all cases I'm aware of, those libraries aren't the choice between "existing huge community-backed project and @ottobackwards personal OSS project." They're typically the only solution, or one of only a handful of a niche set of solutions for a particular problem. I think the main discussion point on https://github.com/apache/metron/pull/1219 was that there were other available solutions that solved the problem well without requiring the need for a custom fork. AFA the original PR that introduced the dependency, https://github.com/apache/metron/pull/1175, the only suggestion I would make going forward from a community perspective is to include a simple reason why a dependency has been added, ie "adding this bc there isn't a library that accomplishes this, it's used on multiple projects, etc." Basically, what Otto already described. TL;DR - I think it's reasonable to request minimal justification for new libraries, and it's something to keep in mind in future PRs. Seems to me this dep is justified as I'm unaware of other alternatives that solve this problem. I am also very much in favor of enabling community members to contribute to, and cross pollinate with, other projects as Otto has done here.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
