justinleet opened a new pull request #1249: METRON-1815: Separate metron-parsers into metron-parsers-common and metron-parsers-storm URL: https://github.com/apache/metron/pull/1249 ## Contributor Comments Separating metron-parsers into metron-parsers-common and metron-parsers-storm in order to decouple the parsers from Storm. This builds on the work from [METRON-1681](https://issues.apache.org/jira/browse/METRON-1681), done here: https://github.com/apache/metron/pull/1213. It looks like a ton of changes, but most of it is pretty minor naming adjustments, moving whole files, etc. Full dev should spin up and run exactly as it does prior to this PR, which is also how to test this. At this point, no org.apache.storm dependency should remain in metron-parsers-common (as that now lives in metron-parsers-storm). This means that we are typically going to be running, for now, off of metron-parsers-storm jars. Nothing changes in Ambari, because there's no actual second platform we're running on. In the future, I'd say we need to make some sort of configuration around this, but I'm fine with that being follow-on whenever we choose to build off of something other than Storm. This also adjusts some of the integration tests, so that it's easier to extend to a new platform once we add something beyond Storm. The current solution would involve a class for every parser for every platform, which seems awful. The new solution uses a parameterized test, and simply one extended class that's platform specific. Let me know thoughts on this and if we want to refactor this differently. The commit history is a little wonky, since this started based on his PR before it made it into master and there was a variety of merging happening there. The commits from @merrimanr are from that branch, not coauthored here. I'm a bit surprised git didn't handle it properly, but it won't matter once squashed. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` #### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
