merrimanr commented on a change in pull request #1308: METRON-1945: Metron MPack support for Knox SSO setup URL: https://github.com/apache/metron/pull/1308#discussion_r243285191
########## File path: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py ########## @@ -51,23 +51,24 @@ metron_group = config['configurations']['metron-env']['metron_group'] metron_log_dir = config['configurations']['metron-env']['metron_log_dir'] metron_pid_dir = config['configurations']['metron-env']['metron_pid_dir'] - +metron_rest_host = status_params.metron_rest_host metron_rest_port = status_params.metron_rest_port metron_management_ui_host = status_params.metron_management_ui_host metron_management_ui_port = status_params.metron_management_ui_port +metron_management_ui_path = metron_home + '/web/management-ui/' metron_alerts_ui_host = status_params.metron_alerts_ui_host metron_alerts_ui_port = status_params.metron_alerts_ui_port +metron_alerts_ui_path = metron_home + '/web/alerts-ui/' metron_jvm_flags = config['configurations']['metron-rest-env']['metron_jvm_flags'] # Construct the profiles as a temp variable first. Only the first time it's set will carry through -metron_spring_profiles_temp = config['configurations']['metron-rest-env']['metron_spring_profiles_active'] -if config['configurations']['metron-security-env']['metron.ldap.enabled']: - if metron_spring_profiles_temp: - metron_spring_profiles_active = metron_spring_profiles_temp + ',ldap' +metron_spring_profiles_active = config['configurations']['metron-rest-env']['metron_spring_profiles_active'] +metron_ldap_enabled = config['configurations']['metron-security-env']['metron.ldap.enabled'] +if metron_ldap_enabled: + if not len(metron_spring_profiles_active) == 0: + metron_spring_profiles_active += ',ldap' Review comment: Are you sure you had to manually add `knox` to the active spring profiles? This should happen automatically on line 465 of this file. If you did have to add it, then there is a bug somewhere. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
