sardell commented on issue #1306: METRON-1941: Alert Escalation Not Consistent in Alerts UI URL: https://github.com/apache/metron/pull/1306#issuecomment-449037266 @nickwallen I tend to agree with @ruffle1986 here. With no unit tests in place, this giant component requires a lot of mocking before we can even run our first test. Since this is a bug fix to an existing component and not a new feature, I feel it's better to confirm with the manual test steps for now, merge it into master and create a separate ticket for achieving decent test coverage for the entire component. It's not a unit test, but if it's any consolation, [I do have a test for this functionality in the Cypress migration work I'm doing](https://github.com/sardell/metron/blob/METRON-1648/metron-interface/metron-alerts/cypress/integration/alert-details/alert-status/alert-details.status.e2e-spec.js#L42) (admittedly, it's commented out because of this bug).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
