merrimanr commented on a change in pull request #1275: METRON-1878: Add Metron
as a Knox service
URL: https://github.com/apache/metron/pull/1275#discussion_r243589993
##########
File path:
metron-interface/metron-config/src/app/sensors/sensor-parser-config-readonly/sensor-parser-config-readonly.component.spec.ts
##########
@@ -259,6 +213,17 @@ class MockSensorEnrichmentConfigService {
}
}
+class MockAppConfigService extends AppConfigService {
Review comment:
The original author of these tests included a duplicate mock service in
every test so I was just following the pattern that was already established. I
agree with you though. I will look into pulling it out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
