nickwallen commented on a change in pull request #1279: METRON-1893 Syslog RFC-3164 parser URL: https://github.com/apache/metron/pull/1279#discussion_r243590483
########## File path: metron-platform/metron-parsing/metron-parsers-common/src/main/java/org/apache/metron/parsers/syslog/Syslog3164Parser.java ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.metron.parsers.syslog; + +import com.github.palindromicity.syslog.AllowableDeviations; +import com.github.palindromicity.syslog.SyslogParser; +import com.github.palindromicity.syslog.SyslogParserBuilder; +import com.github.palindromicity.syslog.SyslogSpecification; + +import java.io.Serializable; +import java.util.EnumSet; +import java.util.Map; + + +/** + * Parser for RFC 3164 messages. + */ +public class Syslog3164Parser extends BaseSyslogParser implements Serializable { Review comment: How are we reasoning about what goes in` metron-parsers-common` versus `metron-parsers`? Maybe this is a conversation that has already been had, but seems like this would go in `metron-parsers` because this is an individual parser. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
