mmiklavc commented on a change in pull request #1312: METRON-1953 Stellar REPL 
Fails on Start
URL: https://github.com/apache/metron/pull/1312#discussion_r243662156
 
 

 ##########
 File path: metron-platform/metron-common/src/main/scripts/stellar
 ##########
 @@ -38,7 +38,7 @@ set -u
 
 export METRON_PARSERS_PLATFORM="${METRON_PARSERS_PLATFORM:-storm}"
 export HBASE_CONFIGS=$(hbase classpath)
-export STELLAR_LIB=$(find $METRON_HOME/lib/ -name 
metron-parsers-${METRON_PARSERS_PLATFORM}*.jar)
+export STELLAR_LIB=$(find $METRON_HOME/lib/ -name metron-parsers-*-uber.jar | 
grep -v "common")
 
 Review comment:
   Could this just be?:
   `export STELLAR_LIB=$(find $METRON_HOME/lib/ -name 
metron-parsers-common-*-uber.jar`
   
   e.g. Running that find command on our parsers dir returns the common uber 
jar for parsers:
   ```
   find metron-platform/metron-parsing -name metron-parsers-common-\*-uber.jar
   
metron-platform/metron-parsing/metron-parsers-common/target/metron-parsers-common-0.7.0-uber.jar
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to