sardell commented on issue #1307: METRON-1944: Unable to Delete a Comment in 
Alerts UI
URL: https://github.com/apache/metron/pull/1307#issuecomment-457513841
 
 
   @ruffle1986 If the amount of mocking and setup you need to do is minimal, I 
think writing a unit test specific to the comment functionality of the alert 
details component should be done in this PR. However, I do see there are no 
unit tests currently setup for the alert details component. If the scope of 
setting up these tests is very time consuming, I think you should create a 
separate JIRA to cover this component with unit tests. That way, we aren't 
delaying the bug fix getting into master.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to