ottobackwards commented on a change in pull request #1330: METRON-1968: 
Messages are lost when a parser produces multiple messages and batch size is 
greater than 1
URL: https://github.com/apache/metron/pull/1330#discussion_r254288200
 
 

 ##########
 File path: 
metron-platform/metron-parsing/metron-parsing-storm/src/test/java/org/apache/metron/parsers/bolt/WriterBoltTest.java
 ##########
 @@ -84,32 +86,39 @@ public SensorParserConfig getSensorParserConfig(String 
sensorType) {
   public void testBatchHappyPath() throws Exception {
     ParserConfigurations configurations = getConfigurations(5);
     String sensorType = "test";
+    WriterBolt bolt = spy(new WriterBolt(new WriterHandler(batchWriter), 
configurations, sensorType));
     List<Tuple> tuples = new ArrayList<>();
+    List<String> messageIds = new ArrayList<>();
     for(int i = 0;i < 5;++i) {
       Tuple t = mock(Tuple.class);
 
 Review comment:
   the format string could be a static final String constant

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to