merrimanr commented on a change in pull request #1330: METRON-1968: Messages 
are lost when a parser produces multiple messages and batch size is greater 
than 1
URL: https://github.com/apache/metron/pull/1330#discussion_r254484884
 
 

 ##########
 File path: 
metron-platform/metron-parsing/metron-parsing-storm/src/main/java/org/apache/metron/parsers/bolt/ParserBolt.java
 ##########
 @@ -326,6 +329,10 @@ protected void handleError(String sensorType, byte[] 
originalMessage, Tuple tupl
     ErrorUtils.handleError(collector, error);
   }
 
 
 Review comment:
   After thinking about this more, hashing the message is definitely not the 
right answer.  The most recent commit uses a java UUID instead.  We can explore 
even more efficient options but this should be an improvement.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to