sardell edited a comment on issue #1307: METRON-1944: Unable to Delete a Comment in Alerts UI URL: https://github.com/apache/metron/pull/1307#issuecomment-459289038 ~~+1. Glad to see the unit test for the comment deletion functionality. Hopefully in the near future, we can extend the unit test coverage for this component, but for now I think this is good. Thanks for the contribution, @ruffle1986!~~ EDIT: @ruffle1986 After further testing, I think I caught a bug in this code (though it may have existed before and didn't show because of the comment deletion being broken). Here are the steps to reproduce: * Open the details panel for an alert * Add a comment, then delete it. * Close and reopen the details panel for the alert you just had open. * The comment reappears. If you delete the comment again and repeat the close/reopen steps, it's finally deleted.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
