MohanDV commented on a change in pull request #1335: METRON-1998: Only one 
sensor is flushed by tick tuple
URL: https://github.com/apache/metron/pull/1335#discussion_r255929330
 
 

 ##########
 File path: 
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java
 ##########
 @@ -326,7 +328,6 @@ public void flushTimeouts(
           || clock.currentTimeMillis() - batchTimeoutInfo[LAST_CREATE_TIME_MS] 
>= batchTimeoutInfo[TIMEOUT_MS]) {
         flush(sensorType, bulkMessageWriter, configurations, messageGetStrategy
 
 Review comment:
   flush will remove an entry from the 'sensorTupleMap' and we are iterating on 
the same collection using iterator, the iterator.next() will throw 
ConcurrentModificationException 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to