MohanDV commented on a change in pull request #1305: METRON-1940:Check if not
and install Elastic search templates / Solr collections when indexing server is
restarted
URL: https://github.com/apache/metron/pull/1305#discussion_r257231835
##########
File path:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_master.py
##########
@@ -119,6 +119,10 @@ def start(self, env, upgrade_type=None):
msg = "WARNING: Elasticsearch index templates could not be
installed. " \
Review comment:
I thought it would be better to throw the exception and let the caller
handling exception based on wether to continue further or not rather handling
the exception inside the method.
I can still handle the exception inside the method and make the method
return the status of the installation of template ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
