merrimanr commented on a change in pull request #1330: METRON-1968: Messages are lost when a parser produces multiple messages and batch size is greater than 1 URL: https://github.com/apache/metron/pull/1330#discussion_r259093991
########## File path: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/FlushPolicy.java ########## @@ -0,0 +1,51 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.metron.writer; + +import org.apache.metron.common.configuration.writer.WriterConfiguration; +import org.apache.metron.common.writer.BulkMessageWriter; +import org.apache.metron.common.writer.BulkWriterMessage; +import org.apache.metron.common.writer.BulkWriterResponse; + +import java.util.List; + +/** + * This interface is used by the {@link org.apache.metron.writer.BulkWriterComponent} to determine if a batch should be flushed + * and handle the {@link org.apache.metron.common.writer.BulkWriterResponse} when a batch is flushed. + */ +public interface FlushPolicy { + + /** + * This method is called whenever messages are passed to {@link BulkWriterComponent#write(String, BulkWriterMessage, BulkMessageWriter, WriterConfiguration)}. + * Each implementation of {@link org.apache.metron.writer.FlushPolicy#shouldFlush(String, WriterConfiguration, int)} will be called in order + * and the first one to return true will trigger a flush and continue on. + * @param sensorType sensor type + * @param configurations configurations + * @param batchSize batch size of messages written + * @return true if batch should be flushed + */ + boolean shouldFlush(String sensorType, WriterConfiguration configurations, int batchSize); Review comment: The latest commit changes it back to the way I had it initially. The `FlushPolicy.shouldFlush` method now accepts a list of messages. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
