JonZeolla opened a new pull request #27: METRON-2013: The bro plugin docker script's topic name should be configurable URL: https://github.com/apache/metron-bro-plugin-kafka/pull/27 ## Contributor Comments This was spurred by the METRON-2003 [review process](apache/metron-bro-plugin-kafka/pull/26). I was a bit conflicted on if passing `--kafka-topic` to `./run_end_to_end.sh` should also modify `in_docker_scripts/configure_bro_plugin.sh` to use the provided topic name (instead of the hard coded "bro"). Looking for feedback - I could see it either way but haven't thought too critically about it yet. ### Testing 1. Modify `in_docker_scripts/configure_bro_plugin.sh` to use the same kafka topic name that you will use below (see comments about this above, under Contributor Comments). 1. Use `./run_end_to_end.sh` with no `--kafka-topic` param, or with `--kafka-topic=anythingbutbro`. The outputs should be the same as before this PR. 1. Confirm that when you provided the kafka topic, it was actually used by running: ``` ./scripts/docker_execute_shell.sh --container-name=kafka ls /data | grep INSERT_KAFKA_TOPIC_NAME_HERE ``` ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron's Bro kafka writer plugin. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [X] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [X] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [X] Have you included steps or a guide to how the change may be verified and tested manually? - [X] Have you ensured that the full suite of tests and checks have been executed via: ``` bro-pkg test $GITHUB_USERNAME/metron-bro-plugin-kafka --version $BRANCH ``` - [X] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Apache Metron's [Vagrant full-dev environment](https://github.com/apache/metron/tree/master/metron-deployment/development/centos6) or the equivalent?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
