nickwallen edited a comment on issue #1341: METRON-614: Eliminate use of the default Charset URL: https://github.com/apache/metron/pull/1341#issuecomment-467115586 I noticed that your work removes all [DefaultCharset](http://errorprone.info/bugpattern/DefaultCharset) warnings from Error Prone. Yay! Can we turn on the error level setting for that check, so that if anyone accidentally re-introduces this the build will fail? I **think** the following change to pom.xml will do that. ``` diff --git a/pom.xml b/pom.xml index 8b660c6c5..187cbde43 100644 --- a/pom.xml +++ b/pom.xml @@ -238,6 +238,9 @@ <compilerArgument>-Xlint:unchecked</compilerArgument> <target>${global_java_version}</target> <showWarnings>true</showWarnings> + <compilerArgs> + <arg>-Xep:DefaultCharset:ERROR</arg> + </compilerArgs> </configuration> <dependencies> ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
