nickwallen commented on a change in pull request #1345: METRON-2012 Unable to 
Execute Stellar Functions Against HBase in the REPL
URL: https://github.com/apache/metron/pull/1345#discussion_r261631928
 
 

 ##########
 File path: metron-platform/metron-elasticsearch/pom.xml
 ##########
 @@ -35,22 +35,28 @@
         </dependency>
         <dependency>
             <groupId>org.apache.metron</groupId>
-            <artifactId>metron-enrichment</artifactId>
 
 Review comment:
   We should never have a dependency on `metron-enrichment`.  This causes all 
sorts of problems as a huge set of transitive dependencies get pulled in, and 
small dependency changes in seemingly unrelated places, can have a huge, ripple 
effect.  
   
   Projects like `metron-enrichment` and `metron-elasticsearch` that include 
deployable artifacts are the "leafs" of our dependency tree and nothing else 
should depend on them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to