tiborm commented on a change in pull request #1350: METRON-2023 [UI] Covering
Grok Parser Creation with Cypress tests
URL: https://github.com/apache/metron/pull/1350#discussion_r262513731
##########
File path: metron-interface/metron-alerts/pom.xml
##########
@@ -22,122 +22,4 @@
</parent>
<artifactId>metron-alerts</artifactId>
<url>https://metron.apache.org/</url>
- <properties>
- <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
- <node.version>v9.11.1</node.version>
- <npm.version>6.2.0</npm.version>
- </properties>
- <dependencies>
- </dependencies>
- <build>
- <plugins>
- <plugin>
- <groupId>com.github.eirslett</groupId>
- <artifactId>frontend-maven-plugin</artifactId>
- <version>1.3</version>
- <configuration>
- <workingDirectory>./</workingDirectory>
- <nodeVersion>${node.version}</nodeVersion>
- <npmVersion>${npm.version}</npmVersion>
-
<npmInheritsProxyConfigFromMaven>false</npmInheritsProxyConfigFromMaven>
- </configuration>
- <executions>
- <execution>
- <phase>generate-resources</phase>
- <id>install node and npm</id>
- <goals>
- <goal>install-node-and-npm</goal>
- </goals>
- </execution>
- <execution>
- <phase>generate-resources</phase>
- <id>npm ci</id>
- <goals>
- <goal>npm</goal>
- </goals>
- <configuration>
- <arguments>ci</arguments>
- </configuration>
- </execution>
- <execution>
- <phase>generate-resources</phase>
- <id>npm run build</id>
- <goals>
- <goal>npm</goal>
- </goals>
- <configuration>
- <arguments>run build</arguments>
- </configuration>
- </execution>
- <execution>
- <phase>test</phase>
- <id>npm testCI</id>
- <goals>
- <goal>npm</goal>
- </goals>
- <configuration>
- <arguments>run testCI</arguments>
- </configuration>
- </execution>
- </executions>
- </plugin>
- <plugin>
- <artifactId>maven-clean-plugin</artifactId>
- <version>3.0.0</version>
- <configuration>
- <filesets>
- <fileset>
- <directory>coverage</directory>
- <followSymlinks>false</followSymlinks>
- </fileset>
- <fileset>
- <directory>dist</directory>
- <followSymlinks>false</followSymlinks>
- </fileset>
- <fileset>
- <directory>node</directory>
- <followSymlinks>false</followSymlinks>
- </fileset>
- <fileset>
- <directory>node_modules</directory>
- <followSymlinks>false</followSymlinks>
- </fileset>
- </filesets>
- </configuration>
- </plugin>
- <plugin>
- <artifactId>maven-assembly-plugin</artifactId>
- <configuration>
- <descriptor>assembly.xml</descriptor>
- </configuration>
- <executions>
- <execution>
- <id>make-assembly</id> <!-- this is used for
inheritance merges -->
- <phase>package</phase> <!-- bind to the packaging
phase -->
- <goals>
- <goal>single</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- <plugin>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>exec-maven-plugin</artifactId>
- <version>1.5.0</version>
- <executions>
- <execution>
- <id>prepend-license-header</id>
- <phase>prepare-package</phase>
- <goals>
- <goal>exec</goal>
- </goals>
- <configuration>
-
<executable>./scripts/prepend_license_header.sh</executable>
- </configuration>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
</project>
Review comment:
I kept the pom.xml to have our two UI's in the maven project tree (makes it
easier to import etc.), but I removed the two UI from the install and test
goals.
Also tried to upgrade to the latest maven-frontend-plugin 1.7.5 but it
hasn't fixed the unzipping issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
