ruffle1986 commented on a change in pull request #1344: METRON-1654: findOne
request after an alert patch returns with the original state of the alert item
URL: https://github.com/apache/metron/pull/1344#discussion_r262961547
##########
File path:
metron-interface/metron-alerts/src/app/alerts/alert-details/alert-details.component.ts
##########
@@ -252,22 +234,15 @@ export class AlertDetailsComponent implements OnInit {
const confirmedSubscription =
this.dialogService.launchDialog(commentText).subscribe(action => {
if (action === ConfirmationType.Confirmed) {
- let deletedCommentWrapper = this.alertCommentsWrapper.splice(index,
1)[0];
Review comment:
Personally, I don't like `splice` and never use it. To see it going away is
like a breath of fresh air.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
