nickwallen commented on a change in pull request #1354: METRON-2032: Create
summary table having list of stellar functions in README
URL: https://github.com/apache/metron/pull/1354#discussion_r266873810
##########
File path: metron-platform/metron-management/README.md
##########
@@ -54,9 +54,22 @@ The functions are split roughly into a few sections:
* File functions - Functions around interacting with local or HDFS files
* Configuration functions - Functions surrounding pulling and pushing configs
from zookeeper
* Parser functions - Functions surrounding adding, viewing, and removing
Parser functions.
+* Indexing functions - Functions surrounding setting indexing parameters
(batch size and timeout), setting the index, enabling/disabling index writer
for sensors.
* Enrichment functions - Functions surrounding adding, viewing and removing
Stellar enrichments as well as managing batch size, batch timeout, and index
names for the enrichment topology configuration
* Threat Triage functions - Functions surrounding adding, viewing and removing
threat triage functions.
+| Type | List of Functions |
| |
| | | |
+| :-----------------------: | :-------------------------------: |
:--------------------------------: |
:---------------------------------------------: | :---------: | :---------: |
:----------: | :------------: |
+| Grok Functions | [`GROK_EVAL`](#grok_eval) |
[`GROK_PREDICT`](#grok_predict) | | | | | |
Review comment:
That's definitely better (no horizontal scrolling), but I would still prefer
just a simple vertical only list for all the functions. That would match more
closely what we have in stellar-common, rather than it being different here.
Or is there somewhere else that we take this approach?
I would certainly be open to being convinced. Why do you prefer this
approach?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
