sardell commented on a change in pull request #1364: METRON-2023 [UI] Covering
Grok Parser Creation with Cypress tests
URL: https://github.com/apache/metron/pull/1364#discussion_r269026831
##########
File path: metron-interface/metron-alerts/package.json
##########
@@ -2,19 +2,18 @@
"name": "metron-alerts",
"version": "0.7.1",
"license": "Apache-2.0",
- "angular-cli": {},
"scripts": {
"build": "./node_modules/@angular/cli/bin/ng build --prod",
"start": "ng serve --aot",
+ "start:prod": "ng serve --prod",
"lint": "tslint \"src/**/*.ts\"",
"test": "ng test --browsers=Chrome",
- "testCI": "ng test --watch=false --browsers=ChromeHeadless && npm run
cypress:ci",
- "pree2e": "webdriver-manager update",
- "e2e": "protractor-flake --protractor-path=./node_modules/.bin/protractor
--max-attempts=3 -- ./protractor.conf.js",
- "cypress:run": "cypress run",
+ "test:ci": "ng test --watch=false --browsers=ChromeHeadless",
+ "cypress": "cypress run",
"cypress:open": "cypress open",
- "cypress:ci": "ng build --prod && run-p --race start:ci cypress:run",
- "start:ci": "node ./scripts/alerts-server.js -c alerts_ui_cypress.yml"
+ "cypress:ci": "start-server-and-test start:prod http-get://localhost:4200
cypress",
Review comment:
:pray: Glad to see we are using the Cypress team's recommended practice of
starting a server and testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
