ruffle1986 commented on issue #1334: METRON-1997: Replace Threat Triage Score Field Slider with Text Box URL: https://github.com/apache/metron/pull/1334#issuecomment-477587413 @sardell > I noticed that when I add a threat triage rule without a name, the rule and score adjustment are shown in the list of rules. If I add a rule with a name, the name and score adjustment are shown and the rule is hidden. I think this can be confusing and hard to parse if a user has many rules because of the way we are displaying the data right now. I think it might be better to use a table to display the rule information. If there isn't a name for a rule, that rule's name column remains blank. You're right. I'll add the table headers for each column to make it clear what's going on. I'm also stretching the table. By this, the icons on the right goes to the right side of the pane. It gives more space to display the name for each rule in an individual column. As a bonus, I'll replace the "whatever icon it is" next to the trash icon with a pencil icon to use the same icons for the same purpose consistently. > I also noticed that in the Threat Triage Rules in the read-only pane there is a word break. Nice catch! 👍 > Your testing instructions include a test button, but it looks like that was removed. Could you just strikeout or remove that part of your instructions? Thanks! Description updated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
