mmiklavc commented on issue #1368: Metron-2053: Refactor metron-enrichment to 
decouple Storm dependencies
URL: https://github.com/apache/metron/pull/1368#issuecomment-478174283
 
 
   I ran through the full test script provided above and everything works as 
expected. 
   
   **Things to note**
   
   - I notice a few instances where there are SLF4J logger warnings in the REST 
logs and from the REPL on startup. I'm unsure whether these are new or not.
   - Using zk_load_configs.sh seems to dump a whole lot of logging detail to 
the CLI - I'm not sure if this is intentional or not, but I'm not a fan of 
having this be the default.
   - I need to refactor the enrichment documentation just a touch - most of it 
belongs with metron-enrichment-storm, but some config related documentation can 
probably live in the root metron-enrichment module.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to