mmiklavc commented on a change in pull request #1367: METRON-2022: Metron rest
creates large number of connections to ZK which causes subsequent connection to
zk fail
URL: https://github.com/apache/metron/pull/1367#discussion_r270597603
##########
File path:
metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrMetaAlertDao.java
##########
@@ -144,10 +144,11 @@ protected String getDefaultSourceTypeField() {
}
};
- SolrClient solrClient = solrDao.getSolrClient(solrDao.getZkHosts());
+ SolrClient solrClient = solrDao.getSolrClient();
Review comment:
I'm still confused as to why we are passing the solr client around in this
fashion. I thought Spring is smart enough to create singletons so that all the
DAO constructors can take a SolrClient arg. See note on
https://github.com/apache/metron/pull/1367/files#r269692863
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
