mmiklavc commented on a change in pull request #1365: Metron-2050:
Automatically populate a list of enrichments from HBase
URL: https://github.com/apache/metron/pull/1365#discussion_r272766112
##########
File path:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml
##########
@@ -121,6 +121,14 @@
<empty-value-valid>true</empty-value-valid>
</value-attributes>
</property>
+ <property>
Review comment:
It took me a bit of effort to figure out how we were doing that, actually.
The way we grab the existing properties for Zookeeper and Kafka is via the
service_advisor code. See:
*
https://github.com/apache/metron/blob/96a66c88e7a62867c6287106a6646d198e2e6a81/metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/service_advisor.py#L130
*
https://github.com/apache/metron/blob/96a66c88e7a62867c6287106a6646d198e2e6a81/metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/service_advisor.py#L142
You effectively grab the values at cluster install time and provide those as
default recommended values for properties that we've defined in the MPack. Here
is the path through that maze:
*
https://github.com/apache/metron/blob/96a66c88e7a62867c6287106a6646d198e2e6a81/metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml#L133
*
https://github.com/apache/metron/blob/96a66c88e7a62867c6287106a6646d198e2e6a81/metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/status_params.py#L111
*
https://github.com/apache/metron/blob/96a66c88e7a62867c6287106a6646d198e2e6a81/metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py#L157
*
https://github.com/apache/metron/blob/96a66c88e7a62867c6287106a6646d198e2e6a81/metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/service_advisor.py#L144
Defined in the env file, loaded into status_params first (so the status
commands can use it), inherited by the params os-specific file (for use during
install), modified during install by the service_advisor script.
Hopefully it makes sense why I did this (though not necessarily why this is
all so esoteric)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
