mmiklavc commented on issue #1377: METRON-2065: Setting Parser Output Topic in Sensor Config is broken URL: https://github.com/apache/metron/pull/1377#issuecomment-481001227 When I first encountered this issue, I was a bit confused because we seem to have unit test coverage for this feature passing, but more than that we have the ability to specify the output writer to use, so a sensor output topic didn't make a whole lot of sense to me, e.g. streaming enrichment uses our `SimpleHbaseEnrichmentWriter` and doesn't write to Kafka. Even so, given your changes in this PR @merrimanr, I think you've found a compromise that works well for all cases. Nice work! It looks like this is changing default behavior a bit, and I think it looks reasonable, but we could use some documentation around what the expected behavior should be. It looks like the order of operations is: * `outputTopic`, if present * else `parserConfig.getOutputTopic()`, if present * else `Constants.ENRICHMENT_TOPIC` Also, where does `outputTopic` come from and how is it different from `parserConfig.getOutputTopic()`? is this from CLI options?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
