ottobackwards commented on a change in pull request #1348: METRON-2018 added
docker tests for kafka plugin
URL: https://github.com/apache/metron/pull/1348#discussion_r273494040
##########
File path: dev-utilities/committer-utils/metron-committer-common
##########
@@ -434,6 +444,35 @@ function run_mvn_build_rpms {
fi
}
+#
+# runs the bro kafka plugin's docker based tests
+#
+function run_bro_docker {
+ cd docker &> /dev/null || { echo "failed to change directory to docker" ;
exit 1; }
+ ./run_end_to_end.sh
+
+ rc=$?; if [[ ${rc} != 0 ]]; then
+ echo "ERROR> FAILED run_end_to_end"
+ exit ${rc}
Review comment:
yeah, I think your point is valid in this scenario. The user can still work
with the environment to do that investigation if they choose, but we should
default to always shutting down as most of the time they are just doing
pass/fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
