JonZeolla commented on issue #1348: METRON-2018 added docker tests for kafka plugin URL: https://github.com/apache/metron/pull/1348#issuecomment-481759715 FYI I used this to prepare and test the commit for METRON-2003 (apache/metron-bro-plugin-kafka#26) without issue. The only thing that I didn't think of when I reviewed this earlier by inspection was that it took the time to rebuild my bro container from scratch. I don't mind this because when we use newer bro-pkg features in the tests or upgrade the version of bro that the tests use it would need to be rebuilt anyway, although I wouldn't push back on adding a y/n question on rebuilding the container. Either as a follow-on or in this PR is fine with me.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
