mmiklavc commented on issue #1372: METRON-2062: Metron Alerts: Accidentally commited `fdescribe` in unit tests URL: https://github.com/apache/metron/pull/1372#issuecomment-483415249 I'm going to merge this. Just a heads up, there is apparently some overlap in this PR with https://github.com/apache/metron/pull/1375. The change on line 34 of metron-interface/metron-alerts/src/app/alerts/alerts-list/alerts-list.component.spec.ts. I thought it worth mentioning because the diff stat with master is a little bit different than what Github shows. This is due to the current HEAD of master that this PR was last merged with. ``` git diff --cached --stat metron-interface/metron-alerts/src/app/shared/time-range/time-range.component.spec.ts | 18 +++++++++++------- metron-interface/metron-alerts/src/app/utils/utils.spec.ts | 2 +- 2 files changed, 12 insertions(+), 8 deletions(-) ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
