nickwallen commented on a change in pull request #1383: METRON-1788 Batch profiler pull profile information from zookeeper URL: https://github.com/apache/metron/pull/1383#discussion_r276255569
########## File path: metron-analytics/metron-profiler-spark/src/main/java/org/apache/metron/profiler/spark/cli/BatchProfilerCLI.java ########## @@ -17,15 +17,20 @@ * limitations under the License. * */ + package org.apache.metron.profiler.spark.cli; -import org.apache.commons.cli.CommandLine; -import org.apache.commons.cli.CommandLineParser; -import org.apache.commons.cli.ParseException; -import org.apache.commons.cli.PosixParser; +import static org.apache.metron.profiler.spark.cli.BatchProfilerCLIOptions.*; Review comment: Can you get rid of the wildcard imports? We don't enforce checkstyle in an automated fashion currently, but let's try to avoid problems for when we do. We try to follow the Google Java standards which [don't like wildcard imports](https://google.github.io/styleguide/javaguide.html#s3.3.1-wildcard-imports). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
