ruffle1986 opened a new pull request #1388: METRON-2085: [UI] Alerts UI Details Pane: naming meta alerts is broken URL: https://github.com/apache/metron/pull/1388 ## Contributor Comments Link to the original ASF Jira: https://issues.apache.org/jira/browse/METRON-2085 1. When you click on the name of the meta alert in the detail pane, the input field to change it appears but there's nothing inside but he current meta alert name should be there (because you're changing that). After applying this patch, the user can see the current meta alert name in the input field. 2. It's impossible to click on the cancel button when it comes to editing the name of the meta alert because an invisible html element covers it (the html element that wraps the close button of the entire pane). After applying this patch the user will be able to click on the cancel button. BONUS: I added some keyboard functionalities which means if the user presses enter after updating the meta alert name, it's going to persist the change i.e. save the new name. When the user presses escape button while editing, it means a "cancel". Test: 1. Go to the meta alerts list screen 2. Click on an existing meta alert row in order to open the details pane. 3. If you don't have any meta alerts in the list, create one because it has to be a meta alert if you want to add a different name. You cannot rename a regular alert. 4. In the opened pane, at the top, you can click on the current name of the meta alert. It turns into an editable input field where you can change the name. 5. It's quite straightforward to test the functionality based on the summary of the problem in the beginning of the description. Try to rename it and save it by hitting enter or clicking on the check icon on the right. Try to rename it and cancel the process by hitting the escape button or clicking on the cross icon next to the check icon on the right. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [X] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [X] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [X] Have you included steps or a guide to how the change may be verified and tested manually? - [X] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [X] Have you written or updated unit tests and or integration tests to verify your changes? - [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [X] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [X] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` #### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
